Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong provisioned_ratio calculation in scheduler's capacity filter while resizing share #29

Open
chuan137 opened this issue Apr 11, 2022 · 3 comments
Labels

Comments

@chuan137
Copy link
Member

In scheduler's capacity filter, the provisioned_ratio is calculated and it must be smaller than the host's max_over_subscription_ratio. The implemented algorithm includes the share size into the numerator of the ratio. It is correct for scheduling new share, but not for resizing shares. In this case, it should includes the share size differences. Scheduling share resizing might fail due to this bug.

provisioned_ratio = ((host_state.provisioned_capacity_gb +
share_size) / total)

@chuan137 chuan137 added the bug label Apr 11, 2022
@Carthaca
Copy link
Collaborator

I think it may be wrongly requesting the current size of the share again, not the delta

@chuan137
Copy link
Member Author

Opened upstream bug report https://bugs.launchpad.net/manila/+bug/1968891

@chuan137
Copy link
Member Author

upstream fix available https://review.opendev.org/c/openstack/manila/+/876229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants