Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Authentication #7

Open
zablon-oigo opened this issue Dec 6, 2023 · 19 comments
Open

User Authentication #7

zablon-oigo opened this issue Dec 6, 2023 · 19 comments
Assignees

Comments

@zablon-oigo
Copy link
Contributor

Authenticate users who want to purchase products based on their email or username

@Collins-Omariba
Copy link
Member

Assigned. I think you should create a users app and put all functionality there. But I am open to suggestions on how you want to do it . After settling on a way, confirm first here then proceed with the development.

@zablon-oigo
Copy link
Contributor Author

I will create a separate app for users, including a custom profile model and login, signup, and logout functionality. Before I proceed, Please let me know if you have any specific fields in mind that you want to include in the user profile.

@mpiers110
Copy link
Contributor

@Maishmike
Copy link

@zablon-oigo in the sign out what's your view on having the sign out redirect to home rather than login

@zablon-oigo
Copy link
Contributor Author

@zablon-oigo in the sign out what's your view on having the sign-out redirect to home rather than login

It can be updated, but my view was that if someone logs out they can still be able to view the product list, but if they add any product to the cart or want to view product details they be required to sign in

@mpiers110
Copy link
Contributor

@zablon-oigo I'm working on the cart, I have already created the logic and the models. I'll add the condition of requiring signing in to add products to the cart

@zablon-oigo
Copy link
Contributor Author

@zablon-oigo I'm working on the cart, I have already created the logic and the models. I'll add the condition of requiring signing in to add products to the cart

great

@DDLoga
Copy link
Contributor

DDLoga commented Dec 11, 2023

someone working on login pages?
path('login/', sign_in, name='login'),
path('logout/', sign_out, name='logout'),
path('signup/', sign_up, name='signup'),

@Maishmike
Copy link

@zablon-oigo ooh yes that makes sense.

@zablon-oigo
Copy link
Contributor Author

someone working on login pages?
path('login/', sign_in, name='login'),
path('logout/', sign_out, name='logout'),
path('signup/', sign_up, name='signup'),

Please expound kindly. do you mean the templates or the logic views?

@DDLoga
Copy link
Contributor

DDLoga commented Dec 12, 2023

more about the templates.
@Collins-Omariba Not sure what's the deliverable of this API (I.E. what API Payload, format etc....) can you please share your vision and expectations..... would be glad to serve;)

@Collins-Omariba
Copy link
Member

more about the templates. @Collins-Omariba Not sure what's the deliverable of this API (I.E. what API Payload, format etc....) can you please share your vision and expectations..... would be glad to serve;)

The project isn't restrictive, the final thing should be a working e-commerce API ( I have seen guys creating templates which is still ok) and there is an emphasis on maximum learning since that is the aim of the community . The only thing to be careful about is any change should be documented or properly done for it to be easy for other devs to contribute too.

@mpiers110
Copy link
Contributor

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike
How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@Collins-Omariba
Copy link
Member

I am ok with this. But first open an issue to update the main readme and properly explain how the project is to go , for new contributors to be able to know .

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@zablon-oigo
Copy link
Contributor Author

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@mpiers110 I'm okay with it, but first @Collins-Omariba what is the state of the project?

@Collins-Omariba
Copy link
Member

Collins-Omariba commented Dec 16, 2023

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@mpiers110 I'm okay with it, but first @Collins-Omariba what is the state of the project?

Can you elaborate more on what you mean by state ?

@zablon-oigo
Copy link
Contributor Author

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@mpiers110 I'm okay with it, but first @Collins-Omariba what is the state of the project?

Can you elaborate more on what you mean by state?

Sorry, I meant progress cause, for the past week, all of you have been silent

@Collins-Omariba
Copy link
Member

@DDLoga @mpiers110 @Collins-Omariba @zablon-oigo @Maishmike How about we work on the backend fully and we create basic templates for rendering the views, and then we'll create an app for the api side of it?

@mpiers110 I'm okay with it, but first @Collins-Omariba what is the state of the project?

Can you elaborate more on what you mean by state?

Sorry, I meant progress cause, for the past week, all of you have been silent

sorry for the late reply, I am a little busy. There aren't any deadlines , the main focus is to collaborate . You can contribute at any time and the same applies to everyone else

@mpiers110
Copy link
Contributor

@zablon-oigo I'm done with the products app. I'm awaiting your part on authentication so that I can add '@login_required'😄to the views and integrate the shopping cart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

5 participants