Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional deprecation Server.IPV6 ? #2097

Open
krajorama opened this issue Jun 5, 2024 · 1 comment
Open

Conditional deprecation Server.IPV6 ? #2097

krajorama opened this issue Jun 5, 2024 · 1 comment
Assignees

Comments

@krajorama
Copy link

I was going to update the use of this SDK in Prometheus, but saw deprecation warnings and got confused. I've never seen a conditional deprecation:

// Deprecated: IPv6: instance IPv6 address (deprecated when `routed_ip_enabled` is `True`).
	IPv6 *ServerIPv6 `json:"ipv6"`

I would argue that if the field is not removed eventually (i.e. kept for the case when router_ip_enabled is False) then this is no deprecation at all and the comment should just say , "always nil when routed_ip_enabled is True".

WDYT?

@krajorama krajorama changed the title Conditional deprecation? Conditional deprecation Server.IPV6 ? Jun 5, 2024
@Codelax
Copy link
Member

Codelax commented Jul 1, 2024

routed_ip_enabled is being pushed as the new default. I find valid to consider this field as deprecated.
The documentation line and the deprecation notice is an input of the team developing this API.
I you have not already I would recommend switching and using routed_ip_enabled.
There is a news report about the change and a blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants