Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating variable names in hotstart.nc #128

Open
kjnam opened this issue Mar 7, 2024 · 6 comments
Open

Updating variable names in hotstart.nc #128

kjnam opened this issue Mar 7, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@kjnam
Copy link
Member

kjnam commented Mar 7, 2024

@josephzhang8 Currently, the variables names in hotstart.nc are not consistent with those in SCHISM output nc files. Unless there is a good reason, I think it is better to use consistent variable names and attributes throughout SCHISM input and output files. It will help us visualize data and develop tools for SCHISM.

@kjnam kjnam added the enhancement New feature or request label Mar 7, 2024
@josephzhang8
Copy link
Member

Thx @kjnam. I'll look into this in the context of other on-going things.

@kjnam
Copy link
Member Author

kjnam commented Mar 8, 2024

@josephzhang8 Thank you. It would be great if hotstart.nc uses UGRID conventions and names as SCHISM output nc files.

@josephzhang8
Copy link
Member

I'm not sure about the benefit; r u saying using UGRID would allow us to visualize hotstart.nc. In any case we can already do that with schismview (python based).

So far we have not really benefitted much from using the UGRID convention.

@kjnam
Copy link
Member Author

kjnam commented Mar 13, 2024

@josephzhang8 We use xarray, which relies on dim names and other attributes heavily. So, consistent var and dim names will be very helpful. I agree that UGRID is less important.

@josephzhang8
Copy link
Member

@kjnam : changing var names in hotstart.nc would trigger many downstream changes. A simple solution may be to just long names to each var as attributes. Would this work?

@kjnam
Copy link
Member Author

kjnam commented Mar 21, 2024

@kjnam In fact, I am OK with the current hotstart variable names, but it is better to have consistent dimension names. Long names or extra attributes that can be mapped would be certainly helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants