From 95a43b551047db097c3c7514477e8ccdd517cf03 Mon Sep 17 00:00:00 2001 From: Gunnar Schaefer Date: Mon, 22 May 2017 16:52:08 -0700 Subject: [PATCH 1/3] Switch to Alpine Linux --- Dockerfile | 18 ++++++++---------- movescu.cc.patch => dcmtk.patch | 17 ++++++++++++++--- 2 files changed, 22 insertions(+), 13 deletions(-) rename movescu.cc.patch => dcmtk.patch (88%) diff --git a/Dockerfile b/Dockerfile index 9d81d5b..a683f91 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,21 +1,19 @@ -FROM buildpack-deps:xenial +FROM python:2.7-alpine -RUN apt-get update && apt-get install -y \ - python-pip \ - && rm -rf /var/lib/apt/lists/* \ - && pip install --upgrade pip setuptools wheel +RUN apk add --no-cache build-base curl -COPY movescu.cc.patch /tmp +COPY dcmtk.patch /tmp RUN cd /tmp \ && curl http://support.dcmtk.org/redmine/attachments/download/87/dcmtk-3.6.1_20150924.tar.gz | tar xz \ && cd dcmtk-* \ - && patch --strip 1 >confdefs.h <<_ACEOF +-#define HAVE_FENV_H 1 + _ACEOF + + fi +diff -Naur dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc dcmtk-3.6.1_20150924.patch/dcmnet/apps/movescu.cc +--- dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc 2015-09-24 07:27:10.000000000 -0500 ++++ dcmtk-3.6.1_20150924.patch/dcmnet/apps/movescu.cc 2017-04-27 17:51:26.000000000 -0500 @@ -53,6 +53,12 @@ #define OFFIS_CONSOLE_APPLICATION "movescu" From b0360b389f8ece3f25ae6d25d7a359f4c17ecbc9 Mon Sep 17 00:00:00 2001 From: Gunnar Schaefer Date: Tue, 23 May 2017 08:17:12 -0700 Subject: [PATCH 2/3] Multistage Docker build --- Dockerfile | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/Dockerfile b/Dockerfile index a683f91..5da17b7 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,16 +1,27 @@ -FROM python:2.7-alpine +FROM alpine as build RUN apk add --no-cache build-base curl -COPY dcmtk.patch /tmp -RUN cd /tmp \ - && curl http://support.dcmtk.org/redmine/attachments/download/87/dcmtk-3.6.1_20150924.tar.gz | tar xz \ - && cd dcmtk-* \ - && patch -p1 Date: Tue, 30 May 2017 15:58:06 -0700 Subject: [PATCH 3/3] Update to latest (patched) dcmtk --- Dockerfile | 5 +++-- dcmtk.patch | 25 +++++++------------------ 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/Dockerfile b/Dockerfile index 5da17b7..d8ce95c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,9 +1,10 @@ FROM alpine as build -RUN apk add --no-cache build-base curl +RUN apk add --no-cache build-base git +RUN git clone git://git.dcmtk.org/dcmtk.git WORKDIR dcmtk -RUN curl http://support.dcmtk.org/redmine/attachments/download/87/dcmtk-3.6.1_20150924.tar.gz | tar xz --strip-components 1 +RUN git checkout -qf 6c5329a82728bee2c7b6c7a05dbff192a2418d87 COPY dcmtk.patch . RUN patch -p1 >confdefs.h <<_ACEOF --#define HAVE_FENV_H 1 - _ACEOF - - fi -diff -Naur dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc dcmtk-3.6.1_20150924.patch/dcmnet/apps/movescu.cc ---- dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc 2015-09-24 07:27:10.000000000 -0500 -+++ dcmtk-3.6.1_20150924.patch/dcmnet/apps/movescu.cc 2017-04-27 17:51:26.000000000 -0500 -@@ -53,6 +53,12 @@ +diff -Naur dcmtk/dcmnet/apps/movescu.cc dcmtk.patched/dcmnet/apps/movescu.cc +--- dcmtk/dcmnet/apps/movescu.cc 2017-05-30 14:10:19.000000000 -0700 ++++ dcmtk.patched/dcmnet/apps/movescu.cc 2017-05-30 14:09:29.000000000 -0700 +@@ -48,6 +48,12 @@ #define OFFIS_CONSOLE_APPLICATION "movescu" @@ -25,9 +14,9 @@ diff -Naur dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc dcmtk-3.6.1_20150924.patc static OFLogger movescuLogger = OFLog::getLogger("dcmtk.apps." OFFIS_CONSOLE_APPLICATION); static char rcsid[] = "$dcmtk: " OFFIS_CONSOLE_APPLICATION " v" -@@ -1170,6 +1176,9 @@ +@@ -1248,6 +1254,9 @@ (*assoc)->params, - dcmAllStorageSOPClassUIDs, numberOfAllDcmStorageSOPClassUIDs, + dcmAllStorageSOPClassUIDs, numberOfDcmAllStorageSOPClassUIDs, transferSyntaxes, numTransferSyntaxes); + /* accept everything not known not to be a storage SOP class */ + cond = acceptUnknownContextsWithPreferredTransferSyntaxes( @@ -35,7 +24,7 @@ diff -Naur dcmtk-3.6.1_20150924/dcmnet/apps/movescu.cc dcmtk-3.6.1_20150924.patc } } if (cond.good()) -@@ -1189,6 +1198,141 @@ +@@ -1267,6 +1276,141 @@ return cond; }