Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siren-tests: "sirenada-stg-t3-micro" job appears in Argus as 'Not Planned' although it runs on a daily basis. #269

Open
rayakurl opened this issue Jul 25, 2023 · 9 comments
Assignees
Labels
Argus bug Something isn't working

Comments

@rayakurl
Copy link

https://jenkins.scylladb.com/job/siren-tests/job/Weekly_Runs/job/sirenada-stg-t3-micro/ appears in Argus as 'Not Planned' although it runs on a daily basis.

@rayakurl rayakurl changed the title siren-tests: sirenada-stg-t3-micro appears in Argus as 'Not Planned' although it runs on a daily basis. siren-tests: "sirenada-stg-t3-micro" job appears in Argus as 'Not Planned' although it runs on a daily basis. Jul 25, 2023
@k0machi k0machi self-assigned this Jul 25, 2023
@k0machi
Copy link
Collaborator

k0machi commented Jul 25, 2023

This is due to the fact that it exits too early, so there are no results, we should make it so that the upload script still submits an empty test to indicate that it happened.

@fruch
Copy link
Contributor

fruch commented Nov 15, 2023

@k0machi

can you explain that is the need changed needed on siren-test pipelines ? (and reference the change @temichus did in SCT)

@k0machi
Copy link
Collaborator

k0machi commented Nov 15, 2023

@k0machi

can you explain that is the need changed needed on siren-test pipelines ? (and reference the change @temichus did in SCT)

Yes, same deal as SCT we need to make similar plugin API that we have there where a test is first created and then populated with data, so that early failures are not hidden from us.

@fruch
Copy link
Contributor

fruch commented Nov 15, 2023

@k0machi

can you explain that is the need changed needed on siren-test pipelines ? (and reference the change @temichus did in SCT)

Yes, same deal as SCT we need to make similar plugin API that we have there where a test is first created and then populated with data, so that early failures are not hidden from us.

And again can you estimate how much work it is ?

@k0machi
Copy link
Collaborator

k0machi commented Nov 15, 2023

And again can you estimate how much work it is ?

I'd say 3 days or so, need to both update argus, its client and pipeline files.

@roydahan
Copy link

The time estimation field is 8 hours, but you say 3 days.
Any workaround we can do here?

Can I see a screenshot of the issue / link to such job?

@roydahan roydahan added bug Something isn't working Argus labels Nov 26, 2023
@k0machi
Copy link
Collaborator

k0machi commented Dec 20, 2023

The issue here is we don't have a stage in those pipelines like we do in SCT that pre-creates argus run when pipeline starts, so currently those pipelines will show nothing in case of early failure, e.g. spot termination (as siren tests submit everything at the end of the run)

@fruch
Copy link
Contributor

fruch commented Dec 20, 2023

The issue here is we don't have a stage in those pipelines like we do in SCT that pre-creates argus run when pipeline starts, so currently those pipelines will show nothing in case of early failure, e.g. spot termination (as siren tests submit everything at the end of the run)

Can you link and point to how such a stage can be added, so we can move this into siren-tests

@k0machi
Copy link
Collaborator

k0machi commented Dec 21, 2023

The issue here is we don't have a stage in those pipelines like we do in SCT that pre-creates argus run when pipeline starts, so currently those pipelines will show nothing in case of early failure, e.g. spot termination (as siren tests submit everything at the end of the run)

Can you link and point to how such a stage can be added, so we can move this into siren-tests

I'll do a write up once #289 is complete with similar steps that need to be done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argus bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants