Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the day of the week thing #3

Open
ratacat opened this issue Oct 23, 2019 · 1 comment
Open

the day of the week thing #3

ratacat opened this issue Oct 23, 2019 · 1 comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@ratacat
Copy link

ratacat commented Oct 23, 2019

 onIncrement() {
      const names = 'MTWHFSU';
      console.log('Day:', names[this.time.day - 1]);
    },

seems like there isn't any current conversion for days (1-30~) to weekdays. for me this.time.day returns 1 to 30~ not 1-7.

@seanohue
Copy link
Owner

Since this is intended for fantastical time systems, for the most part, I would want to make it something more abstract. For instance a way of defining conversions between different units (in this case, day of the month to day of the week).

@seanohue seanohue added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants