Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: Label line-height does not match other inputs #1609

Open
1 task done
gabrieledaugenaite opened this issue Sep 24, 2024 · 1 comment
Open
1 task done
Labels
Comp: Datepicker Type: Bug Something isn't working

Comments

@gabrieledaugenaite
Copy link
Contributor

Bug already reported?

  • I confirm that I have checked if the bug already has been reported

For which framework/library you are reporting the bug

Angular

Component name

datepicker

Description

There seems to be inconsistencies between line-height for label in datepicker component and other input components (dropdown, label + native HTML input).

For dropdown it seems to be set to 1.25rem in transitional styles

For label elements that we use next to native HTML input it also seems to be set to 1.25rem in form mixins

However, datepicker label does not have any line-height set in transitional styles and therefore line-height from _body-default mixin is being used, which is only 1.125rem

{215D6126-DDEF-4128-B064-45A95E00E52F}

Steps To Reproduce

No response

Current Behaviour

No response

Expected Behaviour

No response

@gabrieledaugenaite gabrieledaugenaite added the Type: Bug Something isn't working label Sep 24, 2024
@EldRoos EldRoos changed the title Datepicker label line-height does not match other inputs Datepicker: Label line-height does not match other inputs Sep 26, 2024
@EldRoos
Copy link
Contributor

EldRoos commented Sep 26, 2024

Looks like this problem is in React too. In the design it is centered.
Edit: Ok I misunderstood this. Was looking at datepicker icon, which is not centered but should be.

Label have line height 20px in design, which is 1.25 rem. Correct, so the code should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: Datepicker Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants