Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 resolution is incorrect in TURN #167

Open
4 tasks
ehfd opened this issue Oct 13, 2024 · 1 comment
Open
4 tasks

IPv6 resolution is incorrect in TURN #167

ehfd opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working transport Underlying media or data transport protocols web Web components including gst-web

Comments

@ehfd
Copy link
Member

ehfd commented Oct 13, 2024

TURN pointing to an IPv6 server requires brackets around IPv6 IPs.

  • The current implementation does not place brackets around such IPs, which lead to issues in IPv6-only networks. This must be fixed to represent all cases (IPv4-only, mixed IPv4-IPv6, IPv6-only).
export SELKIES_TURN_HOST="${SELKIES_TURN_HOST:-$(dig TXT +short @ns1.google.com o-o.myaddr.l.google.com 2>/dev/null | { read output; if [ -z "$output" ] || echo "$output" | grep -q '^;;'; then exit 1; else echo "$(echo $output | sed 's,\",,g')"; fi } || dig -6 TXT +short @ns1.google.com o-o.myaddr.l.google.com 2>/dev/null | { read output; if [ -z "$output" ] || echo "$output" | grep -q '^;;'; then exit 1; else echo "$(echo $output | sed 's,\",,g')"; fi } || hostname -I 2>/dev/null | awk '{print $1; exit}' || echo '127.0.0.1')}"
export TURN_EXTERNAL_IP="${TURN_EXTERNAL_IP:-$(getent ahosts ${SELKIES_TURN_HOST} | awk '{print $1; exit}')}"
@ehfd ehfd added bug Something isn't working and removed bug Something isn't working labels Oct 13, 2024
@ehfd ehfd transferred this issue from selkies-project/docker-nvidia-glx-desktop Oct 13, 2024
@ehfd ehfd added bug Something isn't working transport Underlying media or data transport protocols web Web components including gst-web labels Oct 13, 2024
@ehfd
Copy link
Member Author

ehfd commented Oct 13, 2024

@robballantyne This may be the cause of certain issues in several platforms using @ai-dock including Vast.AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transport Underlying media or data transport protocols web Web components including gst-web
Projects
None yet
Development

No branches or pull requests

1 participant