Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sounds bunch after minimized/alt-tabbed and all play at once upon return #14

Open
timbergeron opened this issue Dec 19, 2021 · 2 comments

Comments

@timbergeron
Copy link

Not sure if this is the desired action, but when I return to a game after a minimize or alt-tab all the sounds that occurred since all play at once. This is even more noticeable in multiplayer where many diff sounds will occur. Can we mute all sounds during this time?

https://github.com/sezero/quakespasm/blob/master/Quake/in_sdl.c#L1012

@sezero
Copy link
Owner

sezero commented Dec 19, 2021

@ericwa What do you think?

@Shpoike
Copy link

Shpoike commented Jul 3, 2022

that would break looping sounds (and the cancellation of) if you're not really careful (eg: stand on a moving platform and tab out while waiting for it to stop moving - if you ignore the startsound at the end because of tabbing out then that looping sound will still be playing even though the plat isn't moving (it might also not be retriggerable again and thus impossible to mute).

it'd be better to nudge their timing forward relative to the painttime changes that are no longer happening. done properly it'll just appear as equivalent to muting (doing it only on wakeup would mess up timings for sounds started just before tabbing back in).

the other option is to just not mute the audio while tabbed out - like most(many? some?) modern games do by default. then you can still hear the beep sound etc when other players try talking/shooting at you.

alexey-lysiuk pushed a commit to alexey-lysiuk/quakespasm that referenced this issue Jan 15, 2023
alexey-lysiuk pushed a commit to alexey-lysiuk/quakespasm that referenced this issue Jan 15, 2023
This fixes a potential edict leak after loading a savegame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants