Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming scheme for dimensions in function headers #142

Open
hagenw opened this issue May 5, 2017 · 0 comments
Open

Naming scheme for dimensions in function headers #142

hagenw opened this issue May 5, 2017 · 0 comments

Comments

@hagenw
Copy link
Member

hagenw commented May 5, 2017

As discussed in #141 we have some inconsistencies in the description of dimension length in the function header.
For example

%       x0      - position  and direction of secondary sources [N0x7] / m
%       d       - matrix of driving signals [NxN0]

in driving_function_imp_nfchoa() as opposed to

%       x0      - positions and directions of secondary sources / m [nx6]
%       d       - driving signals [mxn]

in driving_function_imp_wfs().

We should agree on a common naming scheme and create a pull request in order to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant