Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to use addDisallowedApplication instead of protect in VpnService #2608

Closed
zonyitoo opened this issue Dec 2, 2020 · 6 comments
Labels
question Use https://discourse.shadowsocks.org/c/implementations/shadowsocks-android instead.

Comments

@zonyitoo
Copy link

zonyitoo commented Dec 2, 2020

Current implementation relies on a RPC call from the underlying sslocal to the Application to call VpnService.protect, which is for setting a SO_MARK on the socket file descriptor to bypass all outbound data.

But is it possible to make use of VpnService.Builder.addDisallowedApplication?

@zonyitoo zonyitoo added the question Use https://discourse.shadowsocks.org/c/implementations/shadowsocks-android instead. label Dec 2, 2020
@madeye
Copy link
Contributor

madeye commented Dec 2, 2020

It's possible but we want to avoid that.

Because we expect the shadowsocks app itself needs to be proxied, to help testing the connection, fetching remote ACL rules and etc.

@zonyitoo
Copy link
Author

zonyitoo commented Dec 2, 2020

Sounds reasonable.

But with addDisallowedApplication will help simplfied the whole process. RPC calls still have extra overhead.

@zonyitoo zonyitoo closed this as completed Dec 2, 2020
@madeye
Copy link
Contributor

madeye commented Dec 2, 2020

Actually Android system is full of IPC calls: https://developer.android.com/guide/components/aidl

So don't worry about that.

@Mygod
Copy link
Contributor

Mygod commented Dec 2, 2020

#1742

@zonyitoo
Copy link
Author

zonyitoo commented Dec 2, 2020

2018 ... So what's your plan? @Mygod

@Mygod
Copy link
Contributor

Mygod commented Dec 2, 2020

It's abandoned and no plan to revive it. As detailed in the post, it could be used for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Use https://discourse.shadowsocks.org/c/implementations/shadowsocks-android instead.
Projects
None yet
Development

No branches or pull requests

3 participants