Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio switch is not working on Safari #7396

Open
vanminhquangtri opened this issue Oct 4, 2024 · 2 comments
Open

Audio switch is not working on Safari #7396

vanminhquangtri opened this issue Oct 4, 2024 · 2 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@vanminhquangtri
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Yes

What version of Shaka Player are you using?

4.11.2
https://cdnjs.cloudflare.com/ajax/libs/shaka-player/4.11.2/shaka-player.ui.min.js

Can you reproduce the issue with our latest release version?
Link

Can you reproduce the issue with the latest code from main?
Link

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
https://codesandbox.io/p/sandbox/9p35qt?file=%2Findex.html%3A11%2C18-11%2C99

What browser and OS are you using?
Safari 17.6 on macOS Monterey 12.7.6, Safari Iphone 12 Promax, Macbook Pro M1
So I think all Safari will have same issue.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
We not use embedded device.

What are the manifest and license server URIs?

This is non-DRM stream
https://vips-livecdn.fptplay.net/MTA4NDUxNDB8dnR2MS1oZC1tYXVkaW8tc3RhZ2luZ3xmcHR8MTcyODAxMzUxN3wxMDAuOTEuMTI1LjE5MXwxYzFiZDUzYzJkMzYyMDZmOTI3ODI1MDhiMDNlYmFiNA/channel/vtv1-hd-maudio-staging/master.mpd

Attached is manifest content in case you can not access the link
codecs.txt

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default configuration of shaka.

What did you do?

Init player as normal. My stream have 4 audio options, all have same language but different codecs: AAC, AC3, AC351, EAC3. All are supported by Safari.

Please check the demo link.
Click on setting of control bar (3 dots at the right).

What did you expect to happen?
Show audio selection for user to choose codec.
Example from videojs: https://3cvkd4.csb.app/

What actually happened?

There's no audio selection

ONE THING I NOTED is that, the control show a selection for language with 4 options. When you click at any option, it seems shaka does nothing at all.
I think this is a confuse from shaka because all 4 audios have same language (in this case is Vietnamese). So should be NO selection for language. It should be codecs audio selection instead.

Are you planning send a PR to fix it?
Yes I will try If I can

@vanminhquangtri vanminhquangtri added the type: bug Something isn't working correctly label Oct 4, 2024
@shaka-bot shaka-bot added this to the v4.12 milestone Oct 4, 2024
@vanminhquangtri
Copy link
Author

hello @joeyparrish can you please take a look on this, thank you

@avelad
Copy link
Member

avelad commented Oct 18, 2024

@tykus160 Can you review it? You added the codec in the UI in #6723

@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants