From 3fcc317714feed369f2e475a266d81745b96c5bb Mon Sep 17 00:00:00 2001 From: Sharun Date: Fri, 22 Mar 2024 23:58:44 -0700 Subject: [PATCH 1/7] add tests in dockerfile --- Dockerfile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Dockerfile b/Dockerfile index 00ea2c96f..b90504c1c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -28,6 +28,10 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --frozen-lockfile # Copy all source files COPY . ./ +# Tests +RUN pnpm test +RUN pnpm test:typecheck + # Build RUN pnpm build From 84644cef5d2a44569676ecf4ed96ed1330104a4b Mon Sep 17 00:00:00 2001 From: Sharun Date: Fri, 22 Mar 2024 23:58:55 -0700 Subject: [PATCH 2/7] commit bug --- src/features/labels/Ago.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/features/labels/Ago.tsx b/src/features/labels/Ago.tsx index f8988f2ad..70249146f 100644 --- a/src/features/labels/Ago.tsx +++ b/src/features/labels/Ago.tsx @@ -14,7 +14,9 @@ export function formatRelative(date: string): string { addSuffix: false, }); - return getRelativeDateString(relativeDate); + return `${_date > new Date() ? "-" : ""}${getRelativeDateString( + relativeDate, + )}`; } const getRelativeDateString = (relativeDate: string) => { From 4cdc6b4837ee9e6067b2cf0328f9fcedfe0c06ac Mon Sep 17 00:00:00 2001 From: Sharun Date: Sat, 23 Mar 2024 00:03:11 -0700 Subject: [PATCH 3/7] CI=true on pnpm test --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index b90504c1c..502203534 100644 --- a/Dockerfile +++ b/Dockerfile @@ -29,7 +29,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --frozen-lockfile COPY . ./ # Tests -RUN pnpm test +RUN CI=true pnpm test RUN pnpm test:typecheck # Build From bbe6611c35a951acfd6c8ae37c40c488f67c4164 Mon Sep 17 00:00:00 2001 From: Sharun Date: Sat, 23 Mar 2024 00:04:01 -0700 Subject: [PATCH 4/7] Revert "commit bug" This reverts commit 84644cef5d2a44569676ecf4ed96ed1330104a4b. --- src/features/labels/Ago.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/features/labels/Ago.tsx b/src/features/labels/Ago.tsx index 70249146f..f8988f2ad 100644 --- a/src/features/labels/Ago.tsx +++ b/src/features/labels/Ago.tsx @@ -14,9 +14,7 @@ export function formatRelative(date: string): string { addSuffix: false, }); - return `${_date > new Date() ? "-" : ""}${getRelativeDateString( - relativeDate, - )}`; + return getRelativeDateString(relativeDate); } const getRelativeDateString = (relativeDate: string) => { From 01a520b51ff3aa96661f3ca190c9dda9ed7f38c6 Mon Sep 17 00:00:00 2001 From: Sharun Date: Sat, 23 Mar 2024 00:05:57 -0700 Subject: [PATCH 5/7] add --noEmit on tsc --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 502203534..dd86ece64 100644 --- a/Dockerfile +++ b/Dockerfile @@ -30,7 +30,7 @@ COPY . ./ # Tests RUN CI=true pnpm test -RUN pnpm test:typecheck +RUN pnpm test:typecheck --noEmit # Build RUN pnpm build From 2a20dcf73575d595f59b339afd29d1c8d4ace3ff Mon Sep 17 00:00:00 2001 From: Sharun Date: Fri, 22 Mar 2024 23:58:55 -0700 Subject: [PATCH 6/7] commit bug --- src/features/labels/Ago.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/features/labels/Ago.tsx b/src/features/labels/Ago.tsx index f8988f2ad..70249146f 100644 --- a/src/features/labels/Ago.tsx +++ b/src/features/labels/Ago.tsx @@ -14,7 +14,9 @@ export function formatRelative(date: string): string { addSuffix: false, }); - return getRelativeDateString(relativeDate); + return `${_date > new Date() ? "-" : ""}${getRelativeDateString( + relativeDate, + )}`; } const getRelativeDateString = (relativeDate: string) => { From c641e43cc8993ec83ea529ffb5fa6bf00eb95e1f Mon Sep 17 00:00:00 2001 From: Sharun Date: Sat, 23 Mar 2024 00:04:01 -0700 Subject: [PATCH 7/7] Revert "commit bug" This reverts commit 84644cef5d2a44569676ecf4ed96ed1330104a4b. --- src/features/labels/Ago.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/features/labels/Ago.tsx b/src/features/labels/Ago.tsx index 70249146f..f8988f2ad 100644 --- a/src/features/labels/Ago.tsx +++ b/src/features/labels/Ago.tsx @@ -14,9 +14,7 @@ export function formatRelative(date: string): string { addSuffix: false, }); - return `${_date > new Date() ? "-" : ""}${getRelativeDateString( - relativeDate, - )}`; + return getRelativeDateString(relativeDate); } const getRelativeDateString = (relativeDate: string) => {