Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup appkit detection in configure.ac to not need patching later #1879

Closed
alerque opened this issue Oct 5, 2023 · 0 comments · Fixed by #1941
Closed

Fixup appkit detection in configure.ac to not need patching later #1879

alerque opened this issue Oct 5, 2023 · 0 comments · Fixed by #1941
Assignees
@alerque
Labels
tooling Build tooling, release management, and packaging processes
Milestone
v0.15.0

Comments

@alerque
Copy link
Member

alerque commented Oct 5, 2023 •
edited
Loading

Not necessarily related to this change, but I consider such sed hooks rather ugly, and usually they are a result of upstream developers who don't make efforts for their distributors. This is not the case with sile, as development here is very much involved with distribution, so I was wondering whether in the develop branch you would like to make the effort to fix this issue, or at least explain better why is it needed only for Nix builds. Note it is rarely needed in Nixpkgs from my experience.

Originally posted by @doronbehar in #1871 (comment)

Also: #1871 (comment)
@alerque alerque added the tooling Build tooling, release management, and packaging processes label Oct 5, 2023
@alerque alerque added this to the v0.15.0 milestone Oct 5, 2023
@alerque alerque mentioned this issue Oct 5, 2023
Merged
@alerque alerque mentioned this issue Dec 19, 2023
Merged
@alerque alerque self-assigned this Dec 19, 2023
@alerque alerque linked a pull request Dec 21, 2023 that will close this issue
Touchup Mac builds and Nix flake #1941
Merged
@alerque alerque closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alerque alerque

Labels
tooling Build tooling, release management, and packaging processes
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Touchup Mac builds and Nix flake alerque/sile
1 participant
@alerque