diff --git a/ecs-deploy b/ecs-deploy index 25478cc..b93fce6 100755 --- a/ecs-deploy +++ b/ecs-deploy @@ -374,7 +374,7 @@ function createNewTaskDefJson() { # Some options in task definition should only be included in new definition if present in # current definition. If found in current definition, append to JQ filter. - CONDITIONAL_OPTIONS=(networkMode taskRoleArn placementConstraints executionRoleArn runtimePlatform ephemeralStorage) + CONDITIONAL_OPTIONS=(networkMode taskRoleArn placementConstraints executionRoleArn runtimePlatform ephemeralStorage proxyConfiguration) for i in "${CONDITIONAL_OPTIONS[@]}"; do re=".*${i}.*" if [[ "$DEF" =~ $re ]]; then diff --git a/test.bats b/test.bats index 698daf8..00d0e95 100755 --- a/test.bats +++ b/test.bats @@ -686,3 +686,63 @@ EOF [ "$output" == "something:tag_123" ] echo "output = $output" 1>&2 } + +@test "test createNewTaskDefJson with existing proxyConfiguration value" { + imageWithoutTag="121212345678.dkr.ecr.us-east-1.amazonaws.com/acct/repo" + useImage="121212345678.dkr.ecr.us-east-1.amazonaws.com/acct/repo:1111111111" + TASK_DEFINITION=$(cat <