Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CMS6) Update methods which output to both CLI and HTTP responses #11421

Open
GuySartorelli opened this issue Oct 10, 2024 · 0 comments
Open

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 10, 2024

As part of the work to upgrade sake an API has been created that provides a clear way to format output for HTTP vs for CLI.

That upgrade didn't apply it everywhere that currently outputs to the two places. We should update as much code as we can that outputs to both places so that we're doing things consistently.

The places I'm aware of are:

In order to achieve this, we may need a PolyOutput as a singleton, which is set to ANSI output for CLI interaction (sake and when phpunit is bootstrapped), and HTML output for all other scenarios.

Acceptance criteria

  • All code in supported modules that outputs differently based on whether the context is HTTP or CLI uses the new PolyOutput
@GuySartorelli GuySartorelli changed the title Update various methods which output to both CLI and HTTP responses (CMS6) Update various methods which output to both CLI and HTTP responses Oct 10, 2024
@GuySartorelli GuySartorelli changed the title (CMS6) Update various methods which output to both CLI and HTTP responses (CMS6) Update methods which output to both CLI and HTTP responses Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant