Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

It doesn't seem that the check function works when the container is not window #62

Open
danielkorte opened this issue Apr 18, 2018 · 1 comment
Open

It doesn't seem that the check function works when the container is not window #62

danielkorte opened this issue Apr 18, 2018 · 1 comment
Labels
bug

Comments

@danielkorte
Copy link

The check function should call inContainer instead of inViewport.
@silvestreh
Copy link
Owner

you're totally right

@silvestreh silvestreh added the bug label Apr 20, 2018
zvictor added a commit to zvictor/onScreen that referenced this issue May 14, 2019
@zvictor
fix silvestreh#62: check works for specified containers
4a91f17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielkorte @silvestreh