Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audiobridge plugin contribution #3

Open
atyenoria opened this issue Nov 30, 2017 · 2 comments
Open

Audiobridge plugin contribution #3

atyenoria opened this issue Nov 30, 2017 · 2 comments

Comments

@atyenoria
Copy link

Hi, @hpherzog, thank you for nice repo.

I have the plan of creating audiobridge plugin support, cuz I need the server side room controller, not the client one.
Could you tell me how to do this, if possible ?

And, after git clone and npm install, npm-shrinkwrap.json will be changed.
What is the purpose of that ? Probably, #1 met the same problems.

@hpherzog
Copy link
Contributor

hpherzog commented Dec 5, 2017

Thank you @atyenoria. I appriciate it a lot that you have the intention to contribute to this repo. I planned to enrich the client with the other janus plugins anyway, but have not started yet. You can just hook into the existing folder and code structure.

Here some structural conventions as a starting point:

  • Create folder audiobridge in plugins folder

  • Create the same basic files (handle.js, index.js) as in the videoroom folder

  • The audiobridge handle should inherit the basic handle as the videoroom handle. This class is supposed to contain all the handle specific requests and methods.

class AudioBridgeHandle extends PluginHandle {
...
}
  • The same with the plugin, just inherit from the basic plugin to create audiobridge plugin. Here you can place all plugin related things.
class AudioBridgePlugin extends Plugin {
...
}
...
this.audioBridgePlugin = new AudioBridgePlugin({ session: this });
...
audioBridge() {
    return this.audioBridgePlugin;
}
...

I hope this helps to make the first steps.

And, after git clone and npm install, npm-shrinkwrap.json will be changed.
What is the purpose of that ? Probably, #1 met the same problems.

What do exactly mean by "changed"

Best Regards

@atyenoria
Copy link
Author

@hpherzog

Thanks a lot! I will create the PR within a few weeks!

Due to some additional changes in npm-shrinkwrap.json

If I run "npm install", this happens.

How to avoid changing npm-shrinkwrap.json when developing this library?

sipwise-jenkins pushed a commit that referenced this issue Dec 12, 2018
Resolves #4, Resolves #8

Co-authored-by: Cédric <cedbale@gmail.com>
Co-authored-by: Vivien Adnot <vivienadnot@amplement.com>

Squashed commit of the following:

commit 734ef40369afc56c91959f36c3ef09cc5bedfad9
Author: Cédric <cedbale@gmail.com>
Date:   Tue Nov 6 15:17:27 2018 +0100

    fix opaqueID (#3)

commit 72d22049039be12d63c4f53e13323ad717b53704
Author: Cédric <cedbale@gmail.com>
Date:   Mon Oct 29 09:57:25 2018 +0100

    apply new method (#2)

    * add opaqueId
    * fix missing defaultHandle on attach
    * remove attachHandle method from Client (SOC)

commit f8589519f3d3c1dc97c3e3d55e655efc83c3063a
Author: Vivien Adnot <vivienadnot@amplement.com>
Date:   Thu Oct 11 13:49:09 2018 +0200

    moved attach methods into VideoRoomPlugin

commit a2755b86961b518110f9ffb5bb37ad615f94c3b7
Author: Vivien Adnot <vivienadnot@amplement.com>
Date:   Wed Oct 10 15:12:52 2018 +0200

    claim sessions and reconnect handlers done

commit 036de030be030b927cac06e17b835ba7b6a9d284
Author: Cédric <cedricbale@amplement.com>
Date:   Thu Aug 9 13:52:45 2018 +0200

    [WARN] Subscriber is using the legacy 'listener' ptype

commit 5da0695248c2ab01182e0e948d417b112499bcb1
Author: Cédric <cedricbale@amplement.com>
Date:   Tue Aug 7 09:56:11 2018 +0200

    add trickles method to handle mutliple ICE per request

Change-Id: I6b7f33860f575d224940608f8fca541832905f23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants