Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--firefox.includeResponseBodies html not working #4295

Open
2 tasks done
7h3Rabbit opened this issue Oct 12, 2024 · 1 comment
Open
2 tasks done

--firefox.includeResponseBodies html not working #4295

7h3Rabbit opened this issue Oct 12, 2024 · 1 comment
Labels

Comments

@7h3Rabbit
Copy link

Have you read the documentation?

URL

https://webperf.se

What are you trying to accomplish

I'm trying to read html markup from browsertime.har when running sitespeed with firefox browser.
But browsertime.har is not including html markup when runing firefox (but it is when running chrome).
Tested both on Windows (Sandboxed) and Ubunut (Using Github Actions).

You can view test here:

What browser did you use?

Chrome, Firefox

How to reproduce

docker run --rm -v $(pwd):/sitespeed.io sitespeedio/sitespeed.io:35.0.0 -b firefox -n 1 --chrome.includeResponseBodies html --firefox.includeResponseBodies html https://webperf.se

Log output

docker run --rm -v /home/runner/work/sitespeed-firefox-bug/sitespeed-firefox-bug:/sitespeed.io sitespeedio/sitespeed.io:35.0.0 -b firefox -n 1 --chrome.includeResponseBodies html --firefox.includeResponseBodies html https://webperf.se
Unable to find image 'sitespeedio/sitespeed.io:35.0.0' locally
35.0.0: Pulling from sitespeedio/sitespeed.io
857cc8cb19c0: Pulling fs layer
69c6f9388564: Pulling fs layer
e0c7eef1175d: Pulling fs layer
8746099179c3: Pulling fs layer
c9c83c06f5b7: Pulling fs layer
0296b392fddb: Pulling fs layer
27375ee2b756: Pulling fs layer
ba30730b65a5: Pulling fs layer
03142c87294a: Pulling fs layer
efed4e54b554: Pulling fs layer
0af4fda14535: Pulling fs layer
ef9e6263b5b3: Pulling fs layer
e2e44f582f7a: Pulling fs layer
81cc1a287e1c: Pulling fs layer
e891dc2a2c50: Pulling fs layer
0269a7a91184: Pulling fs layer
4f4fb700ef54: Pulling fs layer
e473b47f1cf6: Pulling fs layer
0faf51b80c71: Pulling fs layer
da627538a9d5: Pulling fs layer
d6a3ea5853de: Pulling fs layer
6bf28ff043e6: Pulling fs layer
58e6a44c1ed8: Pulling fs layer
bba691a4e3ce: Pulling fs layer
b5b96c80e988: Pulling fs layer
3df0130f04c9: Pulling fs layer
6507908ba21f: Pulling fs layer
8746099179c3: Waiting
c9c83c06f5b7: Waiting
0269a7a91184: Waiting
0296b392fddb: Waiting
6bf28ff043e6: Waiting
27375ee2b756: Waiting
58e6a44c1ed8: Waiting
bba691a4e3ce: Waiting
ba30730b65a5: Waiting
b5b96c80e988: Waiting
e2e44f582f7a: Waiting
3df0130f04c9: Waiting
03142c87294a: Waiting
6507908ba21f: Waiting
81cc1a287e1c: Waiting
e891dc2a2c50: Waiting
efed4e54b554: Waiting
ef9e6263b5b3: Waiting
e473b47f1cf6: Waiting
da627538a9d5: Waiting
4f4fb700ef54: Waiting
d6a3ea5853de: Waiting
857cc8cb19c0: Verifying Checksum
857cc8cb19c0: Download complete
8746099179c3: Verifying Checksum
8746099179c3: Download complete
69c6f9388564: Verifying Checksum
69c6f9388564: Download complete
857cc8cb19c0: Pull complete
c9c83c06f5b7: Verifying Checksum
c9c83c06f5b7: Download complete
27375ee2b756: Verifying Checksum
27375ee2b756: Download complete
ba30730b65a5: Verifying Checksum
ba30730b65a5: Download complete
03142c87294a: Verifying Checksum
03142c87294a: Download complete
efed4e54b554: Verifying Checksum
efed4e54b554: Download complete
0af4fda14535: Download complete
e0c7eef1175d: Verifying Checksum
e0c7eef1175d: Download complete
ef9e6263b5b3: Verifying Checksum
ef9e6263b5b3: Download complete
e2e44f582f7a: Verifying Checksum
e2e44f582f7a: Download complete
e891dc2a2c50: Verifying Checksum
e891dc2a2c50: Download complete
0269a7a91184: Verifying Checksum
0269a7a91184: Download complete
4f4fb700ef54: Verifying Checksum
4f4fb700ef54: Download complete
e473b47f1cf6: Verifying Checksum
e473b47f1cf6: Download complete
0faf51b80c71: Verifying Checksum
0faf51b80c71: Download complete
81cc1a287e1c: Verifying Checksum
81cc1a287e1c: Download complete
da627538a9d5: Verifying Checksum
da627538a9d5: Download complete
6bf28ff043e6: Verifying Checksum
6bf28ff043e6: Download complete
d6a3ea5853de: Verifying Checksum
d6a3ea5853de: Download complete
bba691a4e3ce: Download complete
58e6a44c1ed8: Download complete
b5b96c80e988: Verifying Checksum
b5b96c80e988: Download complete
3df0130f04c9: Download complete
6507908ba21f: Verifying Checksum
6507908ba21f: Download complete
69c6f9388564: Pull complete
0296b392fddb: Verifying Checksum
0296b392fddb: Download complete
e0c7eef1175d: Pull complete
8746099179c3: Pull complete
c9c83c06f5b7: Pull complete
0296b392fddb: Pull complete
27375ee2b756: Pull complete
ba30730b65a5: Pull complete
03142c87294a: Pull complete
efed4e54b554: Pull complete
0af4fda14535: Pull complete
ef9e6263b5b3: Pull complete
e2e44f582f7a: Pull complete
81cc1a287e1c: Pull complete
e891dc2a2c50: Pull complete
0269a7a91184: Pull complete
4f4fb700ef54: Pull complete
e473b47f1cf6: Pull complete
0faf51b80c71: Pull complete
da627538a9d5: Pull complete
d6a3ea5853de: Pull complete
6bf28ff043e6: Pull complete
58e6a44c1ed8: Pull complete
bba691a4e3ce: Pull complete
b5b96c80e988: Pull complete
3df0130f04c9: Pull complete
6507908ba21f: Pull complete
Digest: sha256:deb67875cd270f05436e120f8adf99a26c467d3d5a51a7701d317fbf99248d8b
Status: Downloaded newer image for sitespeedio/sitespeed.io:35.0.0
Google Chrome 129.0.6668.58 
Mozilla Firefox 130.0
Microsoft Edge 128.0.2739.79 
[2024-10-12 19:43:04] INFO: Versions OS: linux 6.5.0-1025-azure nodejs: v20.17.0 sitespeed.io: 35.0.0 browsertime: 23.0.0 coach: 8.0.2
[2024-10-12 19:43:04] INFO: Running tests using Firefox - 1 iteration(s)
[2024-10-12 19:43:06] INFO: Testing url https://webperf.se iteration 1
[2024-10-12 19:43:17] INFO: Take after page complete check screenshot
[2024-10-12 19:43:17] INFO: Take largest contentful paint screenshot
[2024-10-12 19:43:21] INFO: Use the visual metrics portable script
[2024-10-12 19:43:21] INFO: Get visual metrics from the video
[2024-10-12 19:43:23] INFO: https://webperf.se 50 requests, TTFB: 825ms, firstPaint: 2.14s, firstVisualChange: 2.13s, FCP: 2.13s, DOMContentLoaded: 2.10s, LCP: 2.44s, CPUBenchmark: 62ms, Load: 2.87s, speedIndex: 2.31s, visualComplete85: 2.30s, lastVisualChange: 2.90s
[2024-10-12 19:43:24] INFO: HTML stored in /sitespeed.io/sitespeed-result/webperf.se/2024-10-12-19-43-04
Found browsertime.har at /home/runner/work/sitespeed-firefox-bug/sitespeed-firefox-bug/sitespeed-result/webperf.se/2024-10-12-19-43-04/pages/webperf_se/data/browsertime.har
Error: browsertime.har is not including html file content
@soulgalore
Copy link
Member

Hi @7h3Rabbit thanks for creating the issue! I think this got lost when we changed from https://github.com/firefox-devtools/har-export-trigger to https://github.com/firefox-devtools/bidi-har-export.

The export trigger automatically added bodies for all responses and then we cleaned the HAR depending on the configuration. For Chrome we backfill the HAR bodies using the CDP protocol but for Firefox there's no implementation to do that.

There is firefox-devtools/bidi-har-export#22 tracking this though. I will update the help/code so its clear it doesn't work right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants