Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid token handling #28

Open
coolya opened this issue Oct 10, 2021 · 0 comments
Open

Improve invalid token handling #28

coolya opened this issue Oct 10, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers ide IDE plugin related

Comments

@coolya
Copy link
Member

coolya commented Oct 10, 2021

If the client sends a token that the server does associate with a user it returns a 401 to the client.

The client will present a generic error message that it couldn't create the gist. Ideally we want to client to handle this in a smarter way:

If the client has stored user credentials it is likely that the token it is using got revoked. Most likely be cause the user delete it form their settings. In this case the client should show a notification that prompts the user to start the login workflow from the client to get a valid token.

As a second action the notification should allow the user to retry to upload the gist e.g. when they completed the login workflow.

@coolya coolya added good first issue Good for newcomers ide IDE plugin related enhancement New feature or request labels Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ide IDE plugin related
Projects
None yet
Development

No branches or pull requests

1 participant