Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] : API Authentication Options, HTTPS, More Stable Web Server that http serve #3360

Open
jithinsarath opened this issue Mar 23, 2024 · 4 comments
Labels
serve features/bugs related to sky serve

Comments

@jithinsarath
Copy link

I've combed thru the docs to try and find an answer, without any luck.

  1. Do we have the ability to use a production grade HTTP Server instead of python's in-built one?
  2. Can we implement HTTPS?
  3. When exposing APIs while serving, can we implement authentication?

If a rogue actor gets hold of the IP:Port of a running instance, the costs could go up significantly if there's no auth

I do not expect the project team to solve these, but of there are some directions given, I could take a shot at it.

@concretevitamin
Copy link
Member

Thanks for raising this @jithinsarath.

  1. SkyServe uses Uvicorn at the moment for the controller / load balancer servers. It has not shown up as bottlenecks as of yet due to the compute-heavy nature of GenAI models. Do you foresee for your use cases this may become a bottleneck?
  2. We'd love to get community's help on this! Encrypting the requests/responses will be great to see in SkyServe.
  3. Yes, it should be possible. There are two prototypes of this based on Nginx, from @cblmemo:

We'd like to know more about your requirements to figure out the best ways forward :) Happy to follow up here or on Slack.

@cblmemo
Copy link
Collaborator

cblmemo commented Jun 21, 2024

For 3, we recently added an example on authorization leveraging the underlying serving engine; pls check here :)) Does that suit your need?

@cblmemo cblmemo added the serve features/bugs related to sky serve label Jun 21, 2024
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@cblmemo cblmemo removed the Stale label Oct 20, 2024
@cblmemo
Copy link
Collaborator

cblmemo commented Oct 20, 2024

Quick update: for 2, we have an ongoing PR #3380 and we plan to merge it soon ;) for 1, recently we are exploring the possibility to adopy envoy proxy as our load balancer. Stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serve features/bugs related to sky serve
Projects
None yet
Development

No branches or pull requests

3 participants