Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: nebula-service -test -config should warn about unknown keys and stuff in config yaml #1143

Open
johnmaguire opened this issue May 9, 2024 Discussed in #1142 · 2 comments

Comments

@johnmaguire
Copy link
Collaborator

Discussed in #1142

Originally posted by fooryo May 9, 2024
Idea came from a typo on a yml file.
My yaml was like:

lighthose:
  [...]
  hosts:
    - stuff in here

but nebula-service -test -config host.yml just told me:
WARN[0000] No lighthouse.hosts configured, this host will only be able to initiate tunnels with static_host_map entries

I know that the message is self explanatory but could be and idea that it reports also something like
there is no lighthose on nebula config yaml schema or lighthose key is not an expected key?

A json/yaml schema could also help with the fact that a lighthouse config should not have any lighthouse.hosts in the yaml ( I didnt research why tho ) and helps with a manual writing of such config files.

Thanks

@Akhil-2020171
Copy link

is anyone working on this? if not I can work on this FR.

@johnmaguire
Copy link
Collaborator Author

johnmaguire commented Sep 24, 2024

@Akhil-2020171 AFAIK, nobody is working on this, but it's not straightforward. We do not currently use any sort of struct or definition of the config file. The code will search for certain keys during runtime. There is currently no list of "valid keys" that we can test against. So I think there is really a rearchitecture of the config system that needs to happen for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants