From 05130fea4e2d7d4765ae7292195f4bebf671c8b6 Mon Sep 17 00:00:00 2001 From: Alejandro Hernandez Date: Wed, 14 Feb 2024 13:06:50 -0500 Subject: [PATCH] Fix error when there are no results node includes --- .changeset/khaki-windows-grow.md | 5 +++++ .../src/example-types/results/highlighting/request.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/khaki-windows-grow.md diff --git a/.changeset/khaki-windows-grow.md b/.changeset/khaki-windows-grow.md new file mode 100644 index 000000000..a8b5142fa --- /dev/null +++ b/.changeset/khaki-windows-grow.md @@ -0,0 +1,5 @@ +--- +'contexture-elasticsearch': patch +--- + +Fix error when there are no results node includes diff --git a/packages/provider-elasticsearch/src/example-types/results/highlighting/request.js b/packages/provider-elasticsearch/src/example-types/results/highlighting/request.js index 1006fbfe5..f1dbdcf2d 100644 --- a/packages/provider-elasticsearch/src/example-types/results/highlighting/request.js +++ b/packages/provider-elasticsearch/src/example-types/results/highlighting/request.js @@ -190,7 +190,7 @@ export let getRequestHighlightFields = (schema, node) => { // TODO: `highlightOtherMatches` is an undocumented configuration value that we // are currently using to work around performance issues when highlighting // fields not included in the node. - if (!node.highlight?.highlightOtherMatches) { + if (!node.highlight?.highlightOtherMatches && _.isArray(node.include)) { let subFields = getSchemaSubFields({ fields: _.pick(node.include, schema.fields), })