Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovered a brittleness around boolstruct indentation parsing #445

Open
mengwong opened this issue Sep 25, 2023 · 2 comments
Open

discovered a brittleness around boolstruct indentation parsing #445

mengwong opened this issue Sep 25, 2023 · 2 comments

Comments

@mengwong
Copy link
Contributor

despite numerous tests in the README, while working on the 415 Cheating tab, I encountered one or two scenarios where the indentation constraints around PrePost labels for BoolStructs were stricter than they needed to be, leading to parse errors.

I will try to isolate and follow up with more detail on a reproduction.

Placeholder for now.

@mengwong
Copy link
Contributor Author

experiment on forms like


xxx    yyy1
 OR   yyy2
zzz


xxx         yyy1
        OR yyy2
zzz


        xxx         yyy1
        OR yyy2
zzz


@ym-han
Copy link
Contributor

ym-han commented Oct 3, 2023

@mengwong I would use property-based testing to tackle indentation issues, instead of unit tests. There are usually properties regarding indentation that are not hard to come up with; or at least, it was not hard for me to think of properties I could test the indentation part of the L4 -> LE transpiler with. I can help you with this when we have more time, after the usecase, if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants