Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with magnitude code #44

Open
smutch opened this issue Jul 20, 2020 · 4 comments
Open

What to do with magnitude code #44

smutch opened this issue Jul 20, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@smutch
Copy link
Owner

smutch commented Jul 20, 2020

Should this be left in or kept as as a separately maintained branch? It depends on how flexible the current on-the-fly magnitude calculations are. For example, could the current code be used to calculate the rest frame B band luminosity at z=0.5? If not, then probably best to keep it separate. This will involve removing it from the develop branch.

@smutch smutch added this to the first_release milestone Jul 20, 2020
@smutch smutch self-assigned this Jul 20, 2020
@smutch
Copy link
Owner Author

smutch commented Aug 11, 2020

@yqiuu - Do you have any thoughts here?

@yqiuu
Copy link
Collaborator

yqiuu commented Aug 11, 2020

It is not necessary to remove it from develop branch, because these codes does not do any thing if the flag is off.

@smutch
Copy link
Owner Author

smutch commented Aug 11, 2020

I agree, however, this is working towards a public release of the code. Having everything in there named as general "magnitudes" might make many people think that the code can be used to produce any magnitudes (ie not just restricted to high redshift and/or UV). The question is then - how general is this magnitude code? Can it be used to generate K-band mags at z=0, for example?

@yqiuu
Copy link
Collaborator

yqiuu commented Aug 11, 2020

The code is only able to calculate rest-frame magnitudes with a top-hat filter, but at any given snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants