Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New architecture crashes on React Native < 0.74 (Assertion failed: (hasNativeState<T>(runtime))) #2912

Closed
m-bert opened this issue May 15, 2024 · 2 comments
Assignees

Comments

@m-bert
Copy link
Contributor

m-bert commented May 15, 2024

Description

As reported in this comment, Gesture Handler crashes on new architecture. Here is log from Xcode:

Assertion failed: (hasNativeState<T>(runtime)), function getNativeState, file jsi-inl.h, line 220.

After small investigation we found out that it is caused by changes introduced in #2766 (getting shadowNode in RNGestureHandlerModule.mm)

Steps to reproduce

Just clone reproduction repository and try to run iOS app with new architecture enabled

Snack or a link to a repository

https://github.com/Under-Warz/rngh_sample

Gesture Handler version

2.16.2

React Native version

< 0.74

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

Fabric (New Architecture)

Build type

None

Device

None

Device model

Irrelevant

Acknowledgements

Yes

Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label May 15, 2024
@m-bert m-bert added Maintainer issue and removed Platform: iOS This issue is specific to iOS Missing repro labels May 15, 2024
@m-bert m-bert self-assigned this May 15, 2024
@m-bert
Copy link
Contributor Author

m-bert commented May 15, 2024

After discussion, we decided that our libraries (react-native-gesture-handler, react-native-reanimated, etc.) will support new architecture starting from React Native 0.74. Therefore, we won't be adding backward compatibility in this case.

@m-bert m-bert closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant