Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename contract names from fee to l2 #1266

Open
ddoktorski opened this issue Jan 26, 2024 · 14 comments
Open

Rename contract names from fee to l2 #1266

ddoktorski opened this issue Jan 26, 2024 · 14 comments
Labels

Comments

@ddoktorski
Copy link
Collaborator

Investigate how to verify that there is enough STRK tokens on an account to be deployed using DeployAccountV3.

Discussed here

@ddoktorski ddoktorski added the question Further information is requested label Jan 26, 2024
@ddoktorski
Copy link
Collaborator Author

Both L1_GAS and L2_GAS in the resource_bounds are specified in FRI, hence we can simply call STRK contract to check a balance. We need to decide whether we should perform this check on the starknet.py side at all, since RPC will throw an error if balance is not sufficient anyway. The current error doesn't include token name, it only provides the information Account balance is smaller than the transaction's max_fee..

@ddoktorski ddoktorski added priority: low and removed question Further information is requested labels Jan 31, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

This issue is stale because it has not received any activity in the last 30 days. Remove stale label or add a comment, otherwise it will be closed in 5 days.

@tkumor3
Copy link
Contributor

tkumor3 commented Mar 29, 2024

Current RPC response in the case of having insufficient balance is:

Client failed with code 55. Message: Account validation failed. Data: perform_validations call failed; failure reason: TransactionFailureReason(code='native_blockifier.PyTransactionExecutionError', error_message='TransactionPreValidationError(TransactionFeeError(L1GasBoundsExceedBalance { max_amount: 1109, max_price: 48000000000000, balance_low: StarkFelt("0x0000000000000000000000000000000000000000000000000000000001ad7180"), balance_high: StarkFelt("0x0000000000000000000000000000000000000000000000000000000000000000") }))').

@THenry14 THenry14 changed the title Investigate sufficient balance check in the Account.deploy_account_v3 Rename contract names from fee to l2 Apr 8, 2024
@franciszekjob franciszekjob added the good first issue Good for newcomers label Sep 12, 2024
@Gerson2102
Copy link

Hey I'm Gerson. Member of Dojo Coding. Can I work on this issue? Check my OnlyDust profile, I've contributed to many projects: https://app.onlydust.com/u/Gerson2102

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Gerson2102!
Thanks for showing interest.
We've created an application for you to contribute to Starknet SDK for Python.
Go check it out on OnlyDust!

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Gerson2102!
Thanks for showing interest.
We've created an application for you to contribute to starknet.py.
Go check it out on OnlyDust!

@franciszekjob
Copy link
Collaborator

Hey @Gerson2102, I've assigned you 👍 . Let me know if you need more information to provide a PR for this issue :).

@Gerson2102
Copy link

Reading all the comments inside the issue is not clear for me what I have to do. The name of the issue says one thing and the description says completely other thing, as well as the comments inside of it. Do I have to just rename contract names or see how to verify that there is enough STRK tokens on an account to be deployed? If the second one is the case, where should I put that logic? Is there some resoruces that you guys could share with me or not?

@franciszekjob
Copy link
Collaborator

@Gerson2102 yup, will clarify it and let you know.

@franciszekjob
Copy link
Collaborator

@Gerson2102 this issue #1358 is free and currently it's better to take. Do you want to handle it?

@Gerson2102
Copy link

@franciszekjob yes man, please.

@franciszekjob
Copy link
Collaborator

@Gerson2102 apply for it through OD pls.

@DavidOredu
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

C# programmer here. Interested in taking on your work to rename contract names.

@franciszekjob
Copy link
Collaborator

@DavidOredu we've decided this issue is not for external contributors, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants