Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Asset Parameterization Hints in UI #357

Closed
4 tasks done
richardtreier opened this issue Jul 13, 2023 · 2 comments
Closed
4 tasks done

Display Asset Parameterization Hints in UI #357

richardtreier opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Jul 13, 2023

Feature Request

Description

There is now parameterization for assets with data source of type HttpData, and our assets are created with hint properties, if the data source is of type HttpData.

We need to add this information to the visible asset properties. Right know it's a known asset property, so it won't show up as unknown asset property, but it won't show up at all, until we handle it.

Parameterization hints each can have either be:

  • not set, meaning "null". This happens if the asset wasn't created by our UI, was created faulty.
  • "true" if parameterization is enabled for that field
  • "false" if parameterization is disabled disabled for that field

Solution Proposal and Work Breakdown

  • If no parameterization hints are set, we don't want to show the property.
  • If all parameterization is disabled we want to show "Disabled"
  • If any parameterization hint is set, we want to show it like this: "Http Datasource Parameterization": "Query Params, Body, etc.".
  • If only some parameterization hints are set, we should show them as "Query Params (Unknown)", for example.
@AbdullahMuk
Copy link
Collaborator

Richard will take a look at the pull request so that we can assess if the issue can be closed.

@AbdullahMuk
Copy link
Collaborator

AbdullahMuk commented Nov 6, 2023

PR considered merged according to Richard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants