Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubgraphFusion crashes with IndexError: list index out of range error on certain graphs. #1687

Open
pratyai opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1688
Open

SubgraphFusion crashes with IndexError: list index out of range error on certain graphs. #1687

pratyai opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1688
Labels
bug Something isn't working

Comments

@pratyai
Copy link
Collaborator

pratyai commented Oct 16, 2024

Describe the bug

This came up as I was working with #1673 (i.e. fixing some sub-optimal behaviour of MapFusion causes an unrelated test to break through SubgraphFusion.

While I'd like to fix it myself already, I cannot tell from the subgraph fusion code what it was trying to do here. So, here is an issue for longer-term tracking. In general, the subgraph fusion code looks quite untested and unmaintained. If that's really the case, is it worth to keep SubgraphFusion in the default optimization routine?

To Reproduce

Use this SDFG: https://polybox.ethz.ch/index.php/s/pMlKv8jkJ3B1SdR/download?path=%2F&files=nbody-subgraphfusion-bug.sdfg

With the this code:

import dace
from dace import SDFG
from dace.transformation.auto.auto_optimize import auto_optimize

g = SDFG.from_file('nbody-subgraphfusion-bug.sdfg')
g.validate()
auto_optimize(g, device=dace.dtypes.DeviceType.CPU, validate_all=True)

Expected behavior

It wouldn't crash, and be successful with the fusion.

@pratyai pratyai added the bug Something isn't working label Oct 16, 2024
@pratyai pratyai linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant