Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DictArray -> VarBinView optimize #1111

Open
a10y opened this issue Oct 22, 2024 · 0 comments
Open

DictArray -> VarBinView optimize #1111

a10y opened this issue Oct 22, 2024 · 0 comments

Comments

@a10y
Copy link
Contributor

a10y commented Oct 22, 2024

we should be able to "fast-path" build a VarBinView since we know that the strings in values are unique (doesn't need to be in this PR)

Basically we can construct a VarBinView over the values, and then clone the view once for each code.

This also gets easier if we have #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant