Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Applications must show all (default and non-default) applications #1640

Open
tzolov opened this issue Jan 21, 2021 · 2 comments
Open

UI Applications must show all (default and non-default) applications #1640

tzolov opened this issue Jan 21, 2021 · 2 comments
Labels
type/bug Is a bug report

Comments

@tzolov
Copy link
Contributor

tzolov commented Jan 21, 2021

Currently the applications that don't have at lest one version set as default are not show in the application list.

At the same time the shell's app list as well as the SCDF Rest (http://<scdf-server>:9393/apps) show that the applications are registered.

To reproduce:

As a result the UI will un-register all default apps. But will stop showing the non-default apps. If you use the shell app list or rest http://:9393/apps you will see that the 3.x apps are still registered just the UI doesn't show them.

If you use the shell to an 3.x app to default then it will appear on the UI as well.

@tzolov tzolov added the type/bug Is a bug report label Jan 21, 2021
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jan 21, 2021
@tzolov
Copy link
Contributor Author

tzolov commented Jan 21, 2021

As additional observation and discrepancy :
The shell app all unregister unregisters all apps (default and non-default). While the UI unregisters only the default such.

@jvalkeal jvalkeal removed the status/need-triage Team needs to triage and take a first look label Jan 25, 2021
@sabbyanandan
Copy link
Contributor

Some observations:

  1. Shell/API vs. GUI discrepancy.

  2. Once when a default version is unregistered, we need to either allow it only when a new version is selected or prevent it to avoid the desprecancy.

  3. If a default version is inregistered, we could automatically pick a new default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

3 participants