Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single execution cleanup will not remove pods while task cleanup does #1751

Open
chringwer opened this issue Jul 2, 2021 · 0 comments
Open
Labels
status/need-triage Team needs to triage and take a first look

Comments

@chringwer
Copy link

When hitting the cleanup option under "Tasks" the corresponding REST call has both REMOVE_DATA and CLEANUP set in the action parameter:

taskExecutionsClean(task: Task, completed: boolean): Observable<any> {
const headers = HttpUtils.getDefaultHttpHeaders();
const paramCompleted = completed ? '&completed=true' : '';
const paramTask = task ? `&name=${task.name}` : '';
return this.httpClient
.delete<any>(`/tasks/executions?action=CLEANUP,REMOVE_DATA${paramCompleted}${paramTask}`, {
headers,
observe: 'response'
})
.pipe(
catchError(ErrorUtils.catchError)
);
}

When triggering the cleanup from the "Task Executions" panel only REMOVE_DATA is set and hence the kubernetes pods are left untouched.

executionClean(taskExecution: TaskExecution): Observable<any> {
const headers = HttpUtils.getDefaultHttpHeaders();
return this.httpClient
.delete<any>(`/tasks/executions/${taskExecution.executionId}?action=REMOVE_DATA`, {
headers,
observe: 'response'
})
.pipe(
catchError(ErrorUtils.catchError)
);
}

Is this intentional behaviour? I guess, it should be consistent at least or otherwise reflected in the label somehow so that the user is aware of those options actually behaving differently.

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 2, 2021
@oodamien oodamien pinned this issue Sep 14, 2021
@oodamien oodamien unpinned this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

No branches or pull requests

1 participant