Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control LoadBalancer service #196

Open
jvalkeal opened this issue Mar 9, 2018 · 1 comment
Open

Control LoadBalancer service #196

jvalkeal opened this issue Mar 9, 2018 · 1 comment

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Mar 9, 2018

We don't distinguish LoadBalancer from NodePort, thus service name is derived from appId.

client.services().inNamespace(client.getNamespace()).createNew().withNewMetadata().withName(appId)
.withLabels(idMap).withAnnotations(annotations).addToLabels(SPRING_MARKER_KEY, SPRING_MARKER_VALUE)
.endMetadata().withSpec(spec.build()).done();

With skipper what we want to do is to have control over a created and used LoadBalancer because when we upgrade to a new app from v1 to v2, we may want to keep old LoadBalancer server and then labels of existing applications to potentially do canary deployments.

Maybe as simple as if same name for service exists, we don't need to create it and some sort of property to tell that with undeploy we want to keep service around.

@xetra11
Copy link

xetra11 commented Nov 25, 2019

Really a needed feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants