Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project was build with gradle, instruction to build is using maven, which doesn't work #5

Open
jli226688 opened this issue May 29, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jli226688
Copy link

jli226688 commented May 29, 2024

After "curl https://start.spring.io/starter.tgz -d dependencies=webflux,actuator | tar -xzvf -"

The project only has gradle build settings. No maven at all. So the build image command
"$ ./mvnw spring-boot:build-image -Dspring-boot.build-image.imageName=spring-k8s/gs-spring-boot-k8s"
would not work.

@robertmcnees
Copy link

Hi @jli226688. You're correct that the link provided in the curl example provides only a Gradle project and not maven. The default build system on start.spring.io was switched to Gradle recently.
We should make sure that the link here generates a maven project, as the rest of the learning content and code is a maven project.

@robertmcnees robertmcnees added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Jun 17, 2024
@robertmcnees
Copy link

Adding -d type=maven-project to the URL generates a Maven project. That would make the whole url:

curl https://start.spring.io/starter.tgz -d dependencies=webflux,actuator -d type=maven-project | tar -xzvf -

I'll mark this as a good issue for a first time contribution and a PR. Thanks for finding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants