Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code->Uast Experience #137

Closed
bzz opened this issue Jun 26, 2018 · 4 comments
Closed

Code->Uast Experience #137

bzz opened this issue Jun 26, 2018 · 4 comments

Comments

@bzz
Copy link
Contributor

bzz commented Jun 26, 2018

  1. On interaction between code-uast: is there a chance that we have off-by-one error when choosing a character under cursor?

screen shot 2018-06-26 at 10 10 01 am

  1. When clicking on the UAST, only cursor moves to the position in code, but not the scroll of the code panel - sometimes it is quite had to follow, especially on the filtered UASTs.
    And click on UAST node does not scroll the code either.

  2. Clicking on UAST node *hides( the code selection(cursor) for some reason.
    And to get it back, one needs to move mouse to hover over same UAST node again.

  3. Manual resizing of UAST panel results in a strange "white box" artefact on the left.
    Resizing back removes it.

screen shot 2018-06-26 at 10 16 50 am

@bzz bzz mentioned this issue Jun 26, 2018
@smacker
Copy link
Contributor

smacker commented Jun 26, 2018

  1. bblfsh bug. Similar to Highlight last character (python) bblfsh/web#68 You can see it works correctly for java.
  2. this isn't implemented. Let's file a feature request to bblfsh dashboard?
  3. didn't really get what you mean
  4. Can't reproduce. Could you please provide steps?

@bzz
Copy link
Contributor Author

bzz commented Jun 26, 2018

Do you mean that it's the same as bblfsh/documentation#130 ?

  1. this isn't implemented. Let's file a feature request to bblfsh dashboard?

👍 though, dashboard or uast-viewer?

  1. didn't really get what you mean

Steps to reproduce

  • open Code-> UAST
  • hover UAST node (see it get focus \w cursor)
  • click on same UAST node (see cursor disappear)
    Much more intuitive would be keep Code highlight (and scroll to it)
  1. Can't reproduce. Could you please provide steps?
  • query with code
  • Code -> UAST
  • resize UAST panel to make it bigger by dragging 3 ellipses

@smacker
Copy link
Contributor

smacker commented Jun 26, 2018

  1. Kind of. When drivers start returning consistent position we might need to adjust uast-viewer default transformer.
  2. Good question. Most probably the implementation will be in uast-viewer but uast-viewer isn't a product of src-d. Dashboard is. And playground just re-uses some parts of it.
  3. Ahh. I see. It happens only when highlighting is a cursor, not a selection. Do you think you could create a bug in uast-viewer?
  4. Still can't reproduce. Not in FF nor in Chrome. 😞

@bzz
Copy link
Contributor Author

bzz commented Jun 26, 2018

  1. When drivers start returning consistent position

makes sense, so far - the only tracking point of this from LA seems to be bblfsh/documentation#130 - so waiting for new release and update then

  1. uast-viewer isn't a product of src-d. Dashboard is.

Sounds good, bblfsh/web#136

  1. It happens only when highlighting is a cursor, not a selection

👍
bblfsh/uast-viewer#28

  1. I will test on latest staging again as soon as released and re-open if needed

@bzz bzz closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants