Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements to license binding #25

Closed
hellt opened this issue Oct 14, 2022 · 4 comments
Closed

enhancements to license binding #25

hellt opened this issue Oct 14, 2022 · 4 comments

Comments

@hellt
Copy link
Member

hellt commented Oct 14, 2022

Consider the following use cases for license provisioning:

  1. If a user specifies a model that does not require a license then the tag of their image should not matter

  2. If a user specifies a model that does require a license and the user has provided a single "catch all" license then the tag of their image should not matter

  3. If a user specifies a model that does require a license and the user has not provided a license or has provided a license that matches a specific version other than the one they provided then the failure should clearly output during topology creation

  4. treat ga tag the same as latest

Originally posted by @alexmasi in #24 (comment)

@alexmasi
Copy link
Contributor

Any update on this? Bullet point 2 would be really helpful as we now ingest an image with a license but we reference it as the :ga (generally available) tag

@hellt
Copy link
Member Author

hellt commented Nov 17, 2022

Hi @alexmasi
I replied in IM. As a summary: I will get to it eventually, sorry for the delay. It was not prioritized since we incorporated license into the image

@carlmontanari
Copy link
Contributor

@hellt I think we can close this one if you're good w/ it after #40

@hellt
Copy link
Member Author

hellt commented Feb 2, 2024

ah I think this was also sorted before #40, (point 2), but seems with #40 it is even more robust

@hellt hellt closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants