Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link search doesn't get disabled #711

Open
rezad1393 opened this issue Jun 13, 2024 · 4 comments
Open

link search doesn't get disabled #711

rezad1393 opened this issue Jun 13, 2024 · 4 comments

Comments

@rezad1393
Copy link

I have disabled link option search on context menu.

but right clicking on links still shows the search menu.

this also happens with "page" option even though I have not set any search for page element.

Screenshot_20240613_144906
Screenshot_20240613_144657-1

@ssborbis
Copy link
Owner

I don't think those options ever made it to the newer contextual menus. I'll see about fixing that.

The "page" shouldn't be showing empty folders. Not sure what is going on there. I may need to try your config to see what's going on.

@ssborbis
Copy link
Owner

ssborbis commented Jul 7, 2024

the link fix should be in the master branch if you're sideloading. Otherwise, I hope to get a new release out in a week or so. Lots of changes need testing though

@rezad1393
Copy link
Author

rezad1393 commented Jul 8, 2024

btw outside of link search, when I right click I have "search for page".
is this a limitation of firefox addon that this addon cant know what element it is on before showing menu?

for example if I right clink on a link and it shows "search for link" then right click on another empty part of page, first right click doesn't show the addon submenu at all. then next clicks shows "search for page".

and if I use right click to show the "search for page" then next right click on links doesn't show link search submenu but next right clicks do.

same for right clicking on images after right clicking on links.
same with selection and link.

though to be honest this sound like a separate issue.

@ssborbis
Copy link
Owner

ssborbis commented Jul 29, 2024

This usually happens because the context menu will show immediately, whether the code for this addon has had time to finish or not. So sometimes, you'll see a placeholder where a more descriptive menu title would be, because the menu was built and displayed before the code to get the search terms had time to complete. The webextensions API doesn't give addon developers control over the menu, and we can't alter the menu once it's displayed. So it all comes down to ..............timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants