-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lose ChainId in Provider #1081
Comments
I would like to hop on this @tabaktoni |
@princeibs sorry for later reply, do you want to tackle it? |
Hello @ivpavici is this issue up for contributions? |
@BenFaruna sure, feel free! |
@ivpavici Alright |
GM @ivpavici @tabaktoni, I have looked through the repo and understand how the chainId and provider are linked. However, I have questions, and I want to know if there is a convenient channel for that. Question: |
hi @BenFaruna ! Yes, there are other instances, feel free to make a draft PR! |
Is your feature request related to a problem? Please describe.
get-starkness implement ChainId instead of StarknetChainId
The definition is in starkness-types
Users can set any custom L2/L3 chain ID
Describe the solution you'd like
Accordingly to this as Dhruv suggested Starknetjs should also support adding custom chain ID
This should be enabled/refactored on Provider
Describe alternatives you've considered
There is no alternative (level restrained as it is)
Additional context
get-starknet
starknet-types
The text was updated successfully, but these errors were encountered: