Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for waitForTransaction improvement #1237

Open
Cussone opened this issue Oct 3, 2024 · 4 comments
Open

Proposal for waitForTransaction improvement #1237

Cussone opened this issue Oct 3, 2024 · 4 comments
Labels

Comments

@Cussone
Copy link

Cussone commented Oct 3, 2024

Now that block times are much faster it would make sense to lower the retryInterval param from 5000ms (waited on twice, so it's 10s) to something more realistic.

Also, I find it weird that retryInterval is an optional param. In my opinion, it would make more sense to require it explicitly, with a suggested value in the docs. I see it as a better DX.

This would be a breaking change. So, it is something to consider for the next major release.

@Cussone Cussone added the Type: feature New feature or request label Oct 3, 2024
@martinvibes
Copy link

hello @Cussone can i hop on this issue?

@Cussone
Copy link
Author

Cussone commented Oct 3, 2024

hello @Cussone can i hop on this issue?

Not sure what you are referring to, but feel free to write anything you think about this.

@PhilippeR26
Copy link
Collaborator

Has been discussed in Slack: will not be modified, as user can customize the value.

@Cussone
Copy link
Author

Cussone commented Oct 8, 2024

Has been discussed in Slack: will not be modified, as user can customize the value.

Yup, that was the conclusion for the current version, but I opened this proposal for the next version, as we also discussed on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants