This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
OsResources vs OSConstants
#1682
Comments
|
As both types are exposed, changing the naming of one or the other will be a breaking change and require a major semver bump. |
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this issue
Jun 26, 2024
…ibs#1682) sozo: store ABI and source in metadata registry This PR updates the `sozo build` command to save ABI and expanded source files, into the `target` directory, for the world contract and every user contracts. These ABI and source files are then uploaded as IPFS artifacts in the `ResourceMetadata` registry, for the world, models and contracts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/starkware-libs/blockifier/blob/1f54a54fc143b6a0de365479407a9f6070388865/crates/blockifier/src/versioned_constants.rs#L53C3-L57C1
There are inconsistencies in the naming of types starting with
Os. Should it beOsorOS? It doesn't really matter IMO, as long as it is consistent across the crate.The text was updated successfully, but these errors were encountered: