Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug if you have more than one scss file in your project #3

Closed
matthewp opened this issue Nov 29, 2015 · 4 comments · Fixed by #4
Closed

Possible bug if you have more than one scss file in your project #3

matthewp opened this issue Nov 29, 2015 · 4 comments · Fixed by #4
Assignees
@matthewp
Labels
bug

Comments

@matthewp
Copy link
Member

https://github.com/stealjs/steal-sass/blob/master/main.js#L66
@matthewp matthewp added the bug label Nov 29, 2015
@matthewp matthewp self-assigned this Nov 29, 2015
matthewp added a commit that referenced this issue Dec 1, 2015
@matthewp
getSass should always return a Promise
a8606ea 
Fixes #3

In order to get a Sass object that can be instantiated we first have to
look up whether the web worker is located. To do this the `getSass`
function was created. After it has done the work the first time getSass
simply returns the same sass object. However the use of getSass expects
it to return a Promise, which means it will start throwing after the 2nd
scss file is imported. The fix is simply to always resolve getSass with
a Promise.resolve call.
@matthewp matthewp mentioned this issue Dec 1, 2015
Merged
@Lighttree
Copy link

Hi @matthewp just would like to clarify is this bug related to case when you have one main scss file that imports others ?

For example I do import <can-import from="myApp/assets/styles/styles.scss!" />
And styles.scss has something like:

@import "atoms/_variables.scss";
@import "atoms/_normalize.scss";
@import "bourbon";
@import "atoms/_grid-settings.scss";
@import "atoms/neat/neat";

As a result I have all these "imports" as plain text and uncompiled. I've checked the same approach with Less and it works. Not sure does it makes sense to open new issue for that ?

@matthewp
Copy link
Member Author

@Lighttree Sure, open a new issue. Just so you know, this project is still "alpha" quality and doesn't have the work put into it that less does. If you'd like to contribute that would be good.

@Lighttree
Copy link

@matthewp I've opened new issue: #9 I'll have a look to how it works and if I'll be able to help with this I'll let you know.

@cherifGsoul
Copy link
Contributor

is this corrected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

getSass should always return a Promise stealjs/steal-sass
3 participants
@cherifGsoul @matthewp @Lighttree