Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CI run more than test:browser? #1126

Open
chasenlehara opened this issue Apr 9, 2019 · 0 comments
Open

Should CI run more than test:browser? #1126

chasenlehara opened this issue Apr 9, 2019 · 0 comments
Labels

Comments

@chasenlehara
Copy link
Contributor

Right now, Travis only runs the test:browser script:

- npm run test:browser

The test script has a lot more in it:

"test": "npm run jshint && npm run mocha && npm run test:browser && npm run test:slim-worker-single && npm run test:slim-worker-progressive && npm run test:exports-worker",

I added release scripts and only included test:browser in the preversion script because other tests weren’t passing for me locally.

"preversion": "npm run jshint && npm run test:browser",

Is this expected? Should CI run other tests too? What should be run locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant