Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove broken poly_regular.hpp and related headers #88

Open
Levi-Armstrong opened this issue Jun 6, 2022 · 2 comments
Open

Fix or remove broken poly_regular.hpp and related headers #88

Levi-Armstrong opened this issue Jun 6, 2022 · 2 comments
Labels

Comments

@Levi-Armstrong
Copy link

Levi-Armstrong commented Jun 6, 2022

Acceptance Criteria

  • Determine whether or not poly_regular.hpp belongs in this library.
  • If it does belong, a) add a test case that ensures that this functionality is being included and tested, and b) fix any related issues.

Original Issue: Missing adobe::move_from

The master branch used move_from but I am unable to find it in the source code. Is this an error or been replace?

/*!
Move constructor
*/
poly_regular_instance(move_from<poly_regular_instance> x)
: base_t(move_from<base_t>(x.source)) {}

@Levi-Armstrong
Copy link
Author

It looks like these constructors should be updated to leverage be the following now.

poly_regular_instance(poly_regular_instance&& x) 
         : base_t(std::move(x))) {} 

@camio
Copy link
Contributor

camio commented Jul 15, 2022

This header and its corresponding test do not seem to be part of the CMake build at all, which explains why I don't get any compilation errors coming from this clear error.

@camio camio changed the title Missing adobe::move_from Fix or remove broken poly_regular.hpp and related headers Jul 15, 2022
@camio camio added the bug label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants