Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sulu_form.dynamic_widths has no effect on width selection in form builder #293

Open
soeurdefeo opened this issue Jul 22, 2021 · 2 comments

Comments

@soeurdefeo
Copy link

Q A
Bug? yes
New Feature? no
Bundle Version 2.1.3
Sulu Version 2.3.1
Browser Version all

Actual Behavior

Setting sulu_form.dynamic_widths in config/packages/sulu_form.yaml has no effect on the width selections in the form builder.

Expected Behavior

It should be possible with this config to rename width css classes or remove widths from the form builder.

Possible Solutions

Actually the 2 form fields xml files: https://github.com/sulu/SuluFormBundle/search?l=XML&q=width
Should be replaced by a select type service using that parameter: https://docs.sulu.io/en/2.3/cookbook/select-values-service.html

@niklasnatter
Copy link
Contributor

Thanks for reporting! The proposed solutions sounds good to me - we would happily review a PR if anybody wants to work on this 🙂

@alexander-schranz
Copy link
Member

alexander-schranz commented Aug 2, 2021

Think easiest way to achieve this would be adding a new sulu_form.dynamic_widths_select_provider service which inject the parameter and is used in the form xml like here over the expression type: https://docs.sulu.io/en/2.3/cookbook/select-values-service.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants