Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ... #9

Open
thomas-chris opened this issue Feb 14, 2024 · 1 comment
Open

Bug: ... #9

thomas-chris opened this issue Feb 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@thomas-chris
Copy link

🌎 Environment

  • Xcode: 15.2.0
  • Platform: MacOS/Vapor
  • Version/Release: 0.3.8
  • Dependency manager: SPM

💬 Description

At point of calling public func finalize(pact: Data, completion: ((Result<String, MockServerError>) -> Void)?) my pact data has the correct consumer and provider (as far as i can tell. I am debugging up to the point I can, i can see the consumer and provider set as I expect)

The end result however is a file that is called consumer.provider.json that does not match my expected output file. It also does not overwrite/merge changes and finally the content of the file ends up looking like

"consumer": { "name": "consumer" },

🦶 Reproduction Steps

Reproduction steps are tricky - we are using this is a VAPOR API, not an xcode project and therefor have some extra wrappers. However i can see my data all the way down to this level, then it suddenly changes.

🤔 Expected Results

"consumer": { "name": "consumer" }, should end up with name matching what i have set the consumer to be, not defaulted to consumer.

😲 Actual Results

"consumer": { "name": "consumer" } name has defaulted to consumer

@thomas-chris thomas-chris added the bug Something isn't working label Feb 14, 2024
@surpher
Copy link
Owner

surpher commented Apr 27, 2024

@thomas-chris There was a major refactor done with 172d2c5b, can you update your wrapper to interact with the new interface and check whether the bug persists?

This refactor moves most of the pact building logic and responsibility into libpact_ffi instead of relying on PactSwift to build the Pact's structure and pass it into FFI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants