Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change in requestedAllocationList of Order Placement v2.2 #21

Open
birdflyer-lszo opened this issue Jul 3, 2024 · 3 comments
Assignees

Comments

@birdflyer-lszo
Copy link

birdflyer-lszo commented Jul 3, 2024

Hi,

In Order Placement v2.0.x the accounts property of the requestedAllocation is an array type (see https://github.com/swissfintechinnovations/ca-wealth/blob/main/OrderPlacement.yaml#L354 and https://github.com/swissfintechinnovations/ca-wealth/blob/main/OrderPlacement.yaml#L304) where in version 2.2 it has become a single object (see https://github.com/swissfintechinnovations/ca-wealth/blob/Update-order-placement-api-to-2.2.0/OrderPlacement.yaml#L660). The name accounts of the property still implies plural.

This introduces a breaking change making calls that were working in version 2.0 incompatible with version 2.2. Is that an intentional change? I was a bit surprised to see breaking changes with a minor version.

Thanks for clarification
--Bruno Ritz (ZKB)

@TLusti
Copy link
Collaborator

TLusti commented Jul 3, 2024

Hi Bruno

Thank you for raising this issue.

This breaking change was not introduced intentionally. The intention was, and still is, that the accounts property of the requestedAllocation is an array type, as the property implies.

This will be fixed before this version is released.
Best
Thomas

@birdflyer-lszo
Copy link
Author

Hi Thomas,

thanks a lot for your quick response. I will therefore (at least as an intermediate fix) manually restore the array type so I can continue with the development and then use the fixed version once it has been released.

Cheers
--bruno

andiahlm added a commit that referenced this issue Jul 4, 2024
@andiahlm
Copy link
Collaborator

andiahlm commented Jul 4, 2024

Added fix of the cardinality issue here:
bd9149c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants