Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping signed arithmetic is undefined behavior #42

Open
Lithrein opened this issue Feb 22, 2024 · 0 comments
Open

Wrapping signed arithmetic is undefined behavior #42

Lithrein opened this issue Feb 22, 2024 · 0 comments

Comments

@Lithrein
Copy link
Contributor

tacle-bench/bench/sequential/adpcm_enc/adpcm_enc.c

Line 242 in 6400092

diff = ( diff * ( -( rad * rad ) ) ) / ( ( 2 * inc ) * ( 2 * inc + 1 ) );

This line needs -fwrapv otherwise modern compilers could optimize it wrongly.
Lithrein added a commit to Lithrein/tacle-bench that referenced this issue Feb 22, 2024
@Lithrein
(tacle#42) table-bench: adpcm_enc.c: add -fwrapv
e8017ef 
This code relies on wrapping signed arithmetic which is undefined
behavior unless -fwrapv is explicitly set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lithrein