-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registerInputAndProcess should exist #14
Comments
I am not sure I understand the problem. Are you saying that If it's the former, please provide a unit test that shows the problem. If it's the latter, I tried to introduce |
The latter. The problem is that you have two types of workspace modes (here) -- and it seems like it would be nice for the caller to not have to know about this. Or, is the checking for delta mode just an optimization? Then in which case my complaint is less valid. Alternative to null: You could have registerAndProcessInput(File) return an iterable? Return either empty collection or Arrays.asList(item). It's a bit weird, but less error prone. Yet another alternative, allow registerInputs to work with a single file too, not just directories. I agree that an inputProcessor interface would be annoying. |
Looking at registerInputsAndProcess, it appears that it adds to the result set if the workspace is not in delta mode or if the resource is unmodified. This seems like an internal detail of sorts, would make sense to have registerInputAndProcess that contains that detail for single-input processing.
The text was updated successfully, but these errors were encountered: