Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for compiler arguments #33

Open
fragkakis opened this issue Jan 7, 2016 · 3 comments
Open

Support for compiler arguments #33

fragkakis opened this issue Jan 7, 2016 · 3 comments

Comments

@fragkakis
Copy link

Currently the takari-lifecycle plugin does not provide a way to pass parameters to the compiler. The main use case I have come upon is when using internal Java classes (example StackOverflow question), but there can be arbitrary reasons why someone may need it.

The maven-compiler-plugin does have support for it (see here).

I propose adding a configuration parameter for this.

@ifedorenko
Copy link
Contributor

I would prefer to deal with internal java classes directly instead of providing open-ended arguments parameter.

Takari lifecycle supports two compiler backend, javac and jdt, and I don't see how we can support generic compiler arguments that work across both compilers. It is also not clear how user-provided arguments are expected to interact with arguments generated by the plugin, i.e. what should happen in the user simultaneously specified -source 1.5 and <source>8</source>.

@jvanzyl
Copy link
Contributor

jvanzyl commented Jan 7, 2016

@fragkakis what specific parameter would you like to control? I agree that we need to be able to accommodate common use cases for turning things on/off but I also agree with Igor that a free-for-all would probably not be good.

One could create an implementation that checked a general set of parameters with specific controls in the implementations where you look for conflicts (like Igor's example above) but that's a lot of work. So maybe we can accommodate your request by dealing with your specific case and see if we can make it work.

@fragkakis
Copy link
Author

Hello both,

I want to use the -XDignore.symbol.file flag. This is to be able to use internal java classes which are not included in the symbol file.

For my case, I need the class com.sun.xml.internal.bind.annotation.OverrideAnnotationOf. I do have a workaround, to bring in my classpath the jaxb-core, where the class still exists as com.sun.xml.bind.annotation.OverrideAnnotationOf. However, I would sleep better if I didn't have to add something in my classpath for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants